Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point cilium to talk to the local apiserver or apiserver-proxy #697

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Point cilium to talk to the local apiserver or apiserver-proxy #697

merged 3 commits into from
Sep 27, 2024

Conversation

berkayoz
Copy link
Member

Configure cilium to use the local port of apiserver or apiserver-proxy to communicate with the apiserver instead of the kube-proxy service which should address issues with socketLB

@berkayoz berkayoz marked this pull request as ready for review September 25, 2024 13:58
@berkayoz berkayoz requested a review from a team as a code owner September 25, 2024 13:58
HomayoonAlimohammadi
HomayoonAlimohammadi reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @berkayoz! Left a very minor comment.

src/k8s/pkg/k8sd/features/cilium/network.go Outdated Show resolved Hide resolved
bschimke95
bschimke95 reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some concerns with the localhostaddress replacement with secure port

src/k8s/pkg/k8sd/app/hooks_bootstrap.go Outdated Show resolved Hide resolved
src/k8s/pkg/k8sd/setup/k8s_apiserver_proxy.go Outdated Show resolved Hide resolved
@berkayoz berkayoz mentioned this pull request Sep 26, 2024
Merged
bschimke95
bschimke95 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@bschimke95 bschimke95 merged commit 9e0a43c into main Sep 27, 2024
20 checks passed
@bschimke95 bschimke95 deleted the KU-1658/cilium-local-apiserver branch September 27, 2024 18:20
@bschimke95 bschimke95 mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateoflorido mateoflorido mateoflorido left review comments

@HomayoonAlimohammadi HomayoonAlimohammadi HomayoonAlimohammadi left review comments

@bschimke95 bschimke95 bschimke95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@berkayoz @mateoflorido @HomayoonAlimohammadi @bschimke95